Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keep alive setting on WinHTTP, trace more error codes from WinHTTP #2917

Merged
merged 1 commit into from
May 28, 2024

Conversation

SergeyRyabinin
Copy link
Contributor

@SergeyRyabinin SergeyRyabinin commented Apr 10, 2024

Issue #, if available:
WinHttp client wrapper always logs an error about keep-alive
Description of changes:
Set keep-alive according to the MSFT docs; various logging updates
Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin SergeyRyabinin force-pushed the sr/WinHTTPKeepAlive branch 2 times, most recently from 3f114ec to 4f3fc6c Compare May 24, 2024 22:00
@SergeyRyabinin SergeyRyabinin marked this pull request as ready for review May 24, 2024 22:40
@SergeyRyabinin SergeyRyabinin merged commit 535caef into main May 28, 2024
4 checks passed
@SergeyRyabinin SergeyRyabinin deleted the sr/WinHTTPKeepAlive branch May 28, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants