fix bcrypt api misuse caused memory leak #2919
Conversation
| } | ||
|
|
||
| bool IsValid() const { return m_isValid; } | ||
|
|
||
| BCRYPT_HASH_HANDLE m_hashHandle; | ||
| bool m_isValid; | ||
| DWORD m_hashObjectLength; |
There was a problem hiding this comment.
hello, thanks a lot for this great finding
it seems that you have forgotten to add m_hashBufferLength here
(or more likely have accidentally added m_hashBufferLength to the c-tor member init list).
There was a problem hiding this comment.
hello, thanks a lot for this great finding it seems that you have forgotten to add
m_hashBufferLengthhere (or more likely have accidentally addedm_hashBufferLengthto the c-tor member init list).
yes, there is a typo there, should be m_hashObjectLength, fixed that in the newest commit. Btw, the caller of BCryptHashContext::BCryptHashContext() had missed to remove redundant parameters, also fixed that.
|
double checked, existing typos has been fixed by now, request merge again |
Issue #2918 , if available: S3Client Leaks Memory on Windows caused by BCrypt API Misuse
Description of changes: fix bcrypt api misuse by deconstructing member variables without ommision
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.