Revert "Memory management integration with common runtime libraries." #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
approved these changes
Apr 18, 2024
SergeyRyabinin
force-pushed
the
sr/revertCrtAllocBind
branch
3 times, most recently
from
07492b7
to
6dd5597
Compare
jeking3
approved these changes
Apr 18, 2024
jeking3
reviewed
Apr 18, 2024
There was a problem hiding this comment.
We should also be initializing the logger and installing it before we initialize the CRT, so we log the CRT startup log messages as well. This will also prove the logger has no dependencies on the CRT, and then the mechanism(s) to cleanly shutdown with delays and quiesces around logging can all be removed.
| @@ -210,14 +210,14 @@ namespace Aws | |||
|
|
|||
| Aws::Config::CleanupConfigAndCredentialsCacheManager(); | |||
|
|
|||
| Aws::Client::CoreErrorsMapper::CleanupCoreErrorsMapper(); | |||
There was a problem hiding this comment.
We should also be initializing the logger and installing it before we initialize the CRT, so we log the CRT startup log messages as well. This will also prove the logger has no dependencies on the CRT, and then the mechanism(s) to cleanly shutdown with delays and quiesces around logging can all be removed.
This reverts commit 00f9e66.
in case of custom memory management
SergeyRyabinin
force-pushed
the
sr/revertCrtAllocBind
branch
from
6dd5597
to
a92347a
Compare
SergeyRyabinin
force-pushed
the
sr/revertCrtAllocBind
branch
from
a92347a
to
542f071
Compare
sbiscigl
approved these changes
Apr 23, 2024
DmitriyMusatkin
approved these changes
Apr 23, 2024
SergeyRyabinin
force-pushed
the
sr/revertCrtAllocBind
branch
from
14881ce
to
9754f3e
Compare
…led" This reverts commit ff6d663.
SergeyRyabinin
force-pushed
the
sr/revertCrtAllocBind
branch
from
9754f3e
to
0b850a9
Compare
sbiscigl
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
CRT STL allocator being used in the SDK.
This forces CRT library to be initialized whenever SDK tries to use a custom allocator.
This prevents SDK from shutting down a CRT logger wrapper after shutting down the CRT library.
Description of changes:
apples and oranges;
separate the sheep from the goats;
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.