Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow benchmark test to be build with CRT Client #2953

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented May 9, 2024

Description of changes:

Defaults the benchmark tests to use CRT client, can be optionally turned off. ie.

Build benchmarks with CRT client:
-DBUILD_ONLY="s3;s3-crt;monitoring" -DBUILD_BENCHMARKS=ON -DAWS_SDK_BENCHMARK_USE_CRT=ON

Build benchmarks with vanilla client:
-DBUILD_ONLY="s3;s3-crt;monitoring" -DBUILD_BENCHMARKS=ON -DAWS_SDK_BENCHMARK_USE_CRT=OFF

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review May 9, 2024 17:38
@sbiscigl sbiscigl merged commit 2628384 into main May 9, 2024
4 checks passed
@sbiscigl sbiscigl deleted the crt-benchmark branch May 9, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants