-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix s3 crt checksum calc #3075
Fix s3 crt checksum calc #3075
Conversation
11bef0c
to
76d1a4e
Compare
faeafce
to
9f066a5
Compare
66a7718
to
3a0dd70
Compare
Aws::Testing::InitPlatformTest(options); | ||
Aws::Testing::ParseArgs(argc, argv); | ||
|
||
Aws::InitAPI(options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Begin() goes here and End() right after "ShutdownAPI"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is copy and pasted more or less from what we already do and how we use it in the crt test already
3a0dd70
to
4d649fb
Compare
Description of changes:
right now we don't propagate flexsum configuration to S3Crt, this changes to propagate the configuraiton. Previously the following request would fail.
Additionally this fixes memory leaks that existed in the CRT client that were not being tested before that now exist. This PR additionally re-enables the CRT integration tests so that we don't accidentally miss these issues anymore either.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.