#3084: use factories for client utility classes initialization, better shutdown #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
force-pushed
the
sr/execEpPtrs
branch
from
c5a2ec7
to
f0e8a6e
Compare
SergeyRyabinin
force-pushed
the
sr/execEpPtrs
branch
2 times, most recently
from
728baee
to
64f90ff
Compare
SergeyRyabinin
commented
Aug 26, 2024
| m_signerProvider(Aws::MakeUnique<Aws::Auth::DefaultAuthSignerProvider>(AWS_CLIENT_LOG_TAG, signer)), | ||
| m_httpClient(CreateHttpClient(configuration)), | ||
| m_httpClient(CreateHttpClient( |
There was a problem hiding this comment.
this is wild, I know...
SergeyRyabinin
force-pushed
the
sr/execEpPtrs
branch
from
64f90ff
to
bb864b0
Compare
sbiscigl
approved these changes
Aug 27, 2024
| */ | ||
| std::shared_ptr<RetryStrategy> retryStrategy; | ||
| std::shared_ptr<RetryStrategy> retryStrategy = nullptr; |
There was a problem hiding this comment.
should we make a ClientConfiguration constructor that takes a ProviderFactories instead of push the logic to the client?
There was a problem hiding this comment.
We can do it later.
Additionally, I see no much extra harm in default-initing to default factories and then allowing users to over-write.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3084
Description of changes:
Use factories in the client config instead of pointers to the actual objects
Minor changes
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.