Add a configuration to avoid hot-loop on input polling in streaming #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
force-pushed
the
sr/curlStreamingLowCPU
branch
from
2e889e6
to
08719dc
Compare
sbiscigl
approved these changes
Aug 26, 2024
| else | ||
| { | ||
| char output[1]; | ||
| if (ioStream->readsome(output, 1) > 0) |
There was a problem hiding this comment.
could we use peek? that way we dont have to do any unwinding/rewinding?
There was a problem hiding this comment.
....because of my hacks to make custom IOStream work as an async non-closable stream
peak will always return something ('a' or 'z'), while readsome will return only if there is something to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.