Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smithy signer ctors for older gcc #3095

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix smithy signer ctors for older gcc #3095

merged 1 commit into from
Aug 28, 2024

Conversation

sbiscigl
Copy link
Contributor

Description of changes:

On older GCC core builds with the error

In file included from aws-sdk-cpp/src/aws-cpp-sdk-core/include/smithy/identity/auth/built-in/SigV4AuthScheme.h:13:0,
                 from aws-sdk-cpp/tests/aws-cpp-sdk-core-tests/smithy/client/SmithyClientTest.cpp:8:
aws-sdk-cpp/src/aws-cpp-sdk-core/include/smithy/identity/signer/built-in/SigV4Signer.h: In constructor 'smithy::AwsSigV4Signer::AwsSigV4Signer(const SigV4AuthSchemeParameters&)':
aws-sdk-cpp/src/aws-cpp-sdk-core/include/smithy/identity/signer/built-in/SigV4Signer.h:24:113: error: could not convert 'parameters' from 'const SigV4AuthSchemeParameters {aka const smithy::DefaultAuthSchemeResolverParameters}' to 'Aws::String {aka std::basic_string<char>}'
             :  m_parameters{parameters},legacySigner{nullptr, parameters.serviceName.c_str(), *parameters.region}
                                                                                                                 ^
In file included from aws-sdk-cpp/src/aws-cpp-sdk-core/include/smithy/identity/auth/built-in/SigV4aAuthScheme.h:13:0,
                 from aws-sdk-cpp/tests/aws-cpp-sdk-core-tests/smithy/client/SmithyClientTest.cpp:12:
aws-sdk-cpp/src/aws-cpp-sdk-core/include/smithy/identity/signer/built-in/SigV4aSigner.h: In constructor 'smithy::AwsSigV4aSigner::AwsSigV4aSigner(const SigV4aAuthSchemeParameters&)':
aws-sdk-cpp/src/aws-cpp-sdk-core/include/smithy/identity/signer/built-in/SigV4aSigner.h:36:39: error: could not convert 'parameters' from 'const SigV4aAuthSchemeParameters {aka const smithy::DefaultAuthSchemeResolverParameters}' to 'Aws::String {aka std::basic_string<char>}'
             :  m_parameters{parameters}

Passing DefaultAuthSchemeResolverParameters to singers in the ctors was out of convenience beforehand, so this moves the ctors to use service name and region as that is what is required in the signers

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review August 28, 2024 16:30
@sbiscigl sbiscigl merged commit 6dd34e1 into main Aug 28, 2024
4 checks passed
@sbiscigl sbiscigl deleted the fix-smithy-signer branch August 28, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants