Smithy Bearer Auth

[sbera87]

Issue #, if available:

Description of changes:

Check all that applies:

• Did a review by yourself.
• Added proper tests to cover this PR. (If tests are not applicable, explain.)
• Checked if this PR is a breaking (APIs have been changed) change.
• Checked if this PR will not introduce cross-platform inconsistent behavior.
• Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

• Linux
• Windows
• Android
• MacOS
• IOS
• Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[sbiscigl]

was thinking about this the other day, do we really need this in its own constant or can we just pass the string in the parent ctor i.e.

AuthScheme("Bearer")

we avoid some namespace pollution that way

[sbera87]

I had raised this before (during autha) but we agreed putting this in namespace smithy to comply with what Sergey originally proposed. We do pass it in the base class constructor. I can simply pass the raw string .
Whatever you finalize. I am ok with either

        std::shared_ptr<AwsCredentialIdentityResolverT> identityResolver,
        const Aws::String &serviceName, const Aws::String &region)
        : AuthScheme(BEARER_SIGNER), m_identityResolver{identityResolver},
          m_signer{Aws::MakeShared<smithy::BearerTokenSigner>(
              "BearerTokenAuthScheme", serviceName, region)}

[sbiscigl]

raw string is better in my opinion thinking about it, one less thing in the namespace that is actually internal to us

[sbiscigl]

where did you get this string btw? in the smithy docs its smithy.api#HTTPBearerAuth

[sbera87]

aws-sdk-cpp/tools/code-generation/generator/src/main/java/com/amazonaws/util/awsclientgenerator/transform/C2jModelToGeneratorModelTransformer.java

Line 587 in af8d1fb

operation.setSignerName("Aws::Auth::BEARER_SIGNER");

this is the signer we use.

aws-sdk-cpp/src/aws-cpp-sdk-core/source/auth/signer/AWSAuthBearerSigner.cpp

Line 16 in af8d1fb

const char BEARER_SIGNER[] = "Bearer";

[sbera87]

Are we moving to a new signer name? Coz, that's not what legacy signer name is . If so, an easy change.

[sbiscigl]

why do you think that is the name of the signer? look at what exists for the SigV4AuthSchemeOption
https://github.com/aws/aws-sdk-cpp/blob/main/src/aws-cpp-sdk-core/include/smithy/identity/auth/built-in/SigV4AuthSchemeOption.h#L15

and SigV4aAuthSchemeOption
https://github.com/aws/aws-sdk-cpp/blob/main/src/aws-cpp-sdk-core/include/smithy/identity/auth/built-in/SigV4aAuthSchemeOption.h#L15

this is the AuthScheme name, which as in the SRA reference is named as smithy.api#HTTPBearerAuth. You can find the exact same in the scheme id for java for bearer auth
https://github.com/aws/aws-sdk-java-v2/blob/5253ae375004b0f51036657eda6fc539f9cd2035/core/http-auth/src/main/java/software/amazon/awssdk/http/auth/scheme/BearerAuthScheme.java#L36

[sbiscigl]

same comment as above, maybe we should just inline these to avoid pollution

[sbera87]

I can put it in the class scope to make it better

[sbiscigl]

why not inline this like in sigv4 and sigv4a, what makes this auth scheme different where a client needs this symbol and couldnt access it through BearerTokenAuthSchemeOption::bearerTokenAuthSchemeOption::schemeId

[sbera87]

I can change that but the main reason for having the variable is usage from other places, so that way we just refer to one constant instead of copies elsewhere. I think we should extend this to the other auths too if you like that

[sbiscigl]

we can refer to it other places using BearerTokenAuthSchemeOption::bearerTokenAuthSchemeOption::schemeId without needing the static const char