Added CustomSSOCredentialsProvider to retain higher-level ClientConfiguration #3103
Conversation
|
Duplicate of #2860, which avoids manipulating the |
| } | ||
|
|
||
| private: | ||
| Aws::Client::ClientConfiguration m_clientConfig; |
There was a problem hiding this comment.
There is already a ClientConfiguration in the base SSO credentials provider. Is the duplication intentional?
|
|
||
| namespace Aws { | ||
| namespace Auth { | ||
| class AWS_CORE_API CustomSSOCredentialsProvider : public SSOCredentialsProvider { |
There was a problem hiding this comment.
this class isnt needed we should just be adding a constructor the SSOCredentialsProvider itself, no need to create a indirection.
This is right we should be merging @teo-tsirpanis 's PR instead. Sorry @teo-tsirpanis for not getting to your PR sooner. going to a do a review of it today, from skimming it looks fine though and accomplishes what we want to do. Lets jump over to a conversation on that. @bhavya2109sharma closing this one out and we can work on merging the original . |
|
@teo-tsirpanis left a few comments on your PR, if addressed we can prioritize getting it in. |
Issue #, if available:
Description of changes:
The existing
SSOCredentialsProviderclass was overwriting the higher-levelClientConfigurationsettings, which is leading to issue while authenticating through SSO.Added a new custom provider class calledCustomSSOCredentialsProviderthat inherits fromSSOCredentialsProviderand allows the use of a customClientConfiguration.In the
Reload()method ofCustomSSOCredentialsProvider, a newClientConfigurationobject is created using the providedm_clientConfigmember variable, and theschemeandregionproperties are set before passing it to theSSOCredentialsClientconstructor.This will ensure that the higher-level
ClientConfigurationis retained, and theSSOCredentialsClientis created with the correct configuration.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.