Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows enums conflict #3129

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix windows enums conflict #3129

merged 2 commits into from
Sep 30, 2024

Conversation

jmklix
Copy link
Member

@jmklix jmklix commented Sep 27, 2024

Issue #, if available:
#3120

Description of changes:
fix conflicting enums on windows by using macros

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmklix jmklix linked an issue Sep 30, 2024 that may be closed by this pull request
@jmklix jmklix merged commit 6f321e0 into main Sep 30, 2024
4 checks passed
@jmklix jmklix deleted the HTTP_VERSION_WIN32 branch September 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enums conflicting with macros defined in windows kits
2 participants