Skip to content

Commit

Permalink
Remove explicit Jackson dependency from v2-migration module (#5612)
Browse files Browse the repository at this point in the history
* Remove explicit Jackson dependency from v2-migration module

* Fix build

* Fix exclusion

---------

Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com>
  • Loading branch information
zoewangg and davidh44 authored Sep 23, 2024
1 parent f1e0f55 commit 4447843
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions v2-migration/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
<openrewrite.version>2.17.0</openrewrite.version>
<junit.version>5.10.3</junit.version>
<awssdkjavav1.version>1.12.472</awssdkjavav1.version>
<jacksondatabind.version>2.17.2</jacksondatabind.version>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -82,13 +81,6 @@
<artifactId>rewrite-java-dependencies</artifactId>
<scope>runtime</scope>
</dependency>
<!-- We have to explicitly add jackson dependency to fix import issue
TODO: remove this once it's fixed. See JAVA-7848-->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${jacksondatabind.version}</version>
</dependency>
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>utils</artifactId>
Expand Down Expand Up @@ -236,6 +228,16 @@
<artifactId>test-utils</artifactId>
<version>${awsjavasdk.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</exclusion>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</exclusion>
</exclusions>
</dependency>
</dependencies>

Expand Down

0 comments on commit 4447843

Please sign in to comment.