Skip to content

Commit

Permalink
Remove outdated TODOs (#4656)
Browse files Browse the repository at this point in the history
  • Loading branch information
sugmanue authored Nov 1, 2023
1 parent 0a308d3 commit 6371f5d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import software.amazon.awssdk.annotations.SdkProtectedApi;
import software.amazon.awssdk.annotations.SdkInternalApi;
import software.amazon.awssdk.awscore.endpoints.authscheme.EndpointAuthScheme;
import software.amazon.awssdk.awscore.endpoints.authscheme.SigV4AuthScheme;
import software.amazon.awssdk.awscore.endpoints.authscheme.SigV4aAuthScheme;
Expand All @@ -15,9 +15,7 @@ import software.amazon.awssdk.http.auth.spi.scheme.AuthSchemeOption;
import software.amazon.awssdk.identity.spi.Identity;
import software.amazon.awssdk.utils.Logger;

// TODO(sra-identity-auth): seems like this can be SdkInternalApi, similar to other .resource files in this folder,
// since they are generated in each service module
@SdkProtectedApi
@SdkInternalApi
public final class AuthSchemeUtils {
private static final Logger LOG = Logger.loggerFor(AuthSchemeUtils.class);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,6 @@ public static InputStream getBinaryRequestPayloadStream(ContentStreamProvider st

public static byte[] hash(InputStream input) {
try {
// TODO(sra-identity-and-auth): Performance testing to verify if we should cache message digest instances
// (thread-local)
MessageDigest md = getMessageDigestInstance();
byte[] buf = new byte[4096];
int read = 0;
Expand Down

0 comments on commit 6371f5d

Please sign in to comment.