Validate the bool params

aws · Aug 28, 2023 · 69e9b15 · 69e9b15
1 parent 6d099b1
commit 69e9b15
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/...src/main/java/software/amazon/awssdk/http/auth/aws/crt/internal/signer/V4aProperties.java b/...src/main/java/software/amazon/awssdk/http/auth/aws/crt/internal/signer/V4aProperties.java
@@ -43,8 +43,8 @@ private V4aProperties(BuilderImpl builder) {
         this.credentials = Validate.paramNotNull(builder.credentials, "Credentials");
         this.credentialScope = Validate.paramNotNull(builder.credentialScope, "CredentialScope");
         this.signingClock = Validate.paramNotNull(builder.signingClock, "SigningClock");
-        this.doubleUrlEncode = builder.doubleUrlEncode;
-        this.normalizePath = builder.normalizePath;
+        this.doubleUrlEncode = Validate.getOrDefault(builder.doubleUrlEncode, () -> true);
+        this.normalizePath = Validate.getOrDefault(builder.normalizePath, () -> true);
     }
 
     public AwsCredentialsIdentity getCredentials() {
@@ -78,9 +78,9 @@ public interface Builder {
 
         Builder signingClock(Clock signingClock);
 
-        Builder doubleUrlEncode(boolean doubleUrlEncode);
+        Builder doubleUrlEncode(Boolean doubleUrlEncode);
 
-        Builder normalizePath(boolean normalizePath);
+        Builder normalizePath(Boolean normalizePath);
 
         V4aProperties build();
     }
@@ -89,8 +89,8 @@ private static class BuilderImpl implements Builder {
         private AwsCredentialsIdentity credentials;
         private CredentialScope credentialScope;
         private Clock signingClock;
-        private boolean doubleUrlEncode;
-        private boolean normalizePath;
+        private Boolean doubleUrlEncode;
+        private Boolean normalizePath;
 
         @Override
         public Builder credentials(AwsCredentialsIdentity credentials) {
@@ -111,13 +111,13 @@ public Builder signingClock(Clock signingClock) {
         }
 
         @Override
-        public Builder doubleUrlEncode(boolean doubleUrlEncode) {
+        public Builder doubleUrlEncode(Boolean doubleUrlEncode) {
             this.doubleUrlEncode = doubleUrlEncode;
             return this;
         }
 
         @Override
-        public Builder normalizePath(boolean normalizePath) {
+        public Builder normalizePath(Boolean normalizePath) {
             this.normalizePath = normalizePath;
             return this;
         }