Merge pull request #3580 from aws/zoewang/fixMPU

Fixed contentLength mismatch issue thrown from putObject when multipa…
aws · Jan 17, 2025 · 6cb022a · 6cb022a
2 parents 507c093 + 7de2e18
commit 6cb022a
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/...ftware/amazon/awssdk/services/s3/multipart/S3MultipartClientPutObjectIntegrationTest.java b/...ftware/amazon/awssdk/services/s3/multipart/S3MultipartClientPutObjectIntegrationTest.java
@@ -36,6 +36,8 @@
 import java.util.Optional;
 import java.util.UUID;
 import java.util.zip.CRC32;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
 import java.util.zip.CheckedInputStream;
 import javax.crypto.KeyGenerator;
 import org.apache.commons.lang3.RandomStringUtils;
@@ -75,6 +77,7 @@ public class S3MultipartClientPutObjectIntegrationTest extends S3IntegrationTest
     private static final byte[] CONTENT = RandomStringUtils.randomAscii(OBJ_SIZE).getBytes(Charset.defaultCharset());
     private static File testFile;
     private static S3AsyncClient mpuS3Client;
+    private static ExecutorService executorService = Executors.newFixedThreadPool(2);
 
     @BeforeAll
     public static void setup() throws Exception {
@@ -97,6 +100,7 @@ public static void teardown() throws Exception {
         mpuS3Client.close();
         testFile.delete();
         deleteBucketAndAllContents(TEST_BUCKET);
+        executorService.shutdown();
     }
 
     @BeforeEach
@@ -120,6 +124,27 @@ void putObject_fileRequestBody_objectSentCorrectly() throws Exception {
         assertThat(ChecksumUtils.computeCheckSum(objContent)).isEqualTo(expectedSum);
     }
 
+    @Test
+    void putObject_inputStreamAsyncRequestBody_objectSentCorrectly() throws Exception {
+        AsyncRequestBody body = AsyncRequestBody.fromInputStream(
+            new ByteArrayInputStream(CONTENT),
+            Long.valueOf(OBJ_SIZE),
+            executorService);
+        mpuS3Client.putObject(r -> r.bucket(TEST_BUCKET)
+                                    .key(TEST_KEY)
+                                    .contentLength(Long.valueOf(OBJ_SIZE)), body).join();
+
+        assertThat(CAPTURING_INTERCEPTOR.createMpuChecksumAlgorithm).isEqualTo("CRC32");
+        assertThat(CAPTURING_INTERCEPTOR.uploadPartChecksumAlgorithm).isEqualTo("CRC32");
+
+        ResponseInputStream<GetObjectResponse> objContent = s3.getObject(r -> r.bucket(TEST_BUCKET).key(TEST_KEY),
+                                                                         ResponseTransformer.toInputStream());
+
+        assertThat(objContent.response().contentLength()).isEqualTo(testFile.length());
+        byte[] expectedSum = ChecksumUtils.computeCheckSum(Files.newInputStream(testFile.toPath()));
+        assertThat(ChecksumUtils.computeCheckSum(objContent)).isEqualTo(expectedSum);
+    }
+
     @Test
     void putObject_byteAsyncRequestBody_objectSentCorrectly() throws Exception {
         byte[] bytes = RandomStringUtils.randomAscii(OBJ_SIZE).getBytes(Charset.defaultCharset());

diff --git a/...in/java/software/amazon/awssdk/services/s3/internal/multipart/SdkPojoConversionUtils.java b/...in/java/software/amazon/awssdk/services/s3/internal/multipart/SdkPojoConversionUtils.java
@@ -51,7 +51,7 @@ public final class SdkPojoConversionUtils {
 
     protected static final Set<String> PUT_OBJECT_REQUEST_TO_UPLOAD_PART_FIELDS_TO_IGNORE =
         new HashSet<>(Arrays.asList("ChecksumSHA1", "ChecksumSHA256", "ContentMD5", "ChecksumCRC32C", "ChecksumCRC32",
-                                    "ChecksumCRC64NVME"));
+                                    "ChecksumCRC64NVME", "ContentLength"));
 
     private SdkPojoConversionUtils() {
     }