Skip to content

Commit

Permalink
Change aws-sdk-java to an optional dependency
Browse files Browse the repository at this point in the history
Having it as a normal dependency causes third dependencies like SLF4J to also
be included, unshaded in the JAR.
  • Loading branch information
dagnir committed Dec 20, 2023
1 parent 17cf852 commit e1e1f7c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "bugfix",
"category": "AWS SDK for Java v2 Bundle",
"contributor": "",
"description": "Fix an issue where external dependencies are also included unshaded in in the `bundle` JAR."
}
1 change: 1 addition & 0 deletions bundle-sdk/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
<groupId>software.amazon.awssdk</groupId>
<artifactId>aws-sdk-java</artifactId>
<version>${awsjavasdk.version}</version>
<optional>true</optional>
</dependency>
</dependencies>

Expand Down

0 comments on commit e1e1f7c

Please sign in to comment.