Fix spotbugs issues

aws · Aug 28, 2023 · f6f4624 · f6f4624
1 parent 46e853c
commit f6f4624
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/build-tools/src/main/resources/software/amazon/awssdk/spotbugs-suppressions.xml b/build-tools/src/main/resources/software/amazon/awssdk/spotbugs-suppressions.xml
@@ -135,6 +135,12 @@
         <Bug pattern="EI_EXPOSE_REP" />
     </Match>
 
+    <Match>
+        <Class name="software.amazon.awssdk.http.auth.aws.crt.internal.signer.V4aContext" />
+        <Method name="getSignature" />
+        <Bug pattern="EI_EXPOSE_REP" />
+    </Match>
+
     <Match>
         <Class name="software.amazon.awssdk.protocols.json.internal.unmarshall.JsonProtocolUnmarshaller" />
         <Method name="unmarshallStructured" />

diff --git a/...src/main/java/software/amazon/awssdk/http/auth/aws/crt/internal/signer/RollingSigner.java b/...src/main/java/software/amazon/awssdk/http/auth/aws/crt/internal/signer/RollingSigner.java
@@ -83,14 +83,12 @@ private static AwsSigningResult signTrailerHeaders(Map<String, List<String>> hea
      * Using a template that incorporates the previous calculated signature, sign the string and return it.
      */
     public byte[] sign(byte[] chunkBody) {
-        previousSignature = signChunk(chunkBody, previousSignature, signingConfig);
-        return previousSignature;
+        return signChunk(chunkBody, previousSignature, signingConfig);
     }
 
     public byte[] sign(Map<String, List<String>> headerMap) {
         AwsSigningResult result = signTrailerHeaders(headerMap, previousSignature, signingConfig);
-        previousSignature = result != null ? result.getSignature() : null;
-        return previousSignature;
+        return result != null ? result.getSignature() : null;
     }
 
     public void reset() {