Skip to content

Commit

Permalink
Add japicmp exclusion for USER_REGION
Browse files Browse the repository at this point in the history
  • Loading branch information
cenedhryn committed Sep 13, 2024
1 parent ea8c30c commit fcb336d
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 41 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import software.amazon.awssdk.annotations.SdkProtectedApi;

/**
* Represents AWS SDK user agent client and request level values.
* Represents AWS SDK user agent client values.
*/
@NotThreadSafe
@SdkProtectedApi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ public void when_requestContainsApiName_apiNamesArePresent() throws Exception {
List<String> userAgentHeaders = request.headers().get(HEADER_USER_AGENT);
assertThat(userAgentHeaders).isNotNull().hasSize(1);
assertThat(userAgentHeaders.get(0)).contains("myLib/1.0");
System.out.println(userAgentHeaders.get(0));
}

@Test
Expand All @@ -131,7 +130,6 @@ public void when_identityContainsProvider_authSourceIsPresent() throws Exception
List<String> userAgentHeaders = request.headers().get(HEADER_USER_AGENT);
assertThat(userAgentHeaders).isNotNull().hasSize(1);
assertThat(userAgentHeaders.get(0)).contains("auth-source#proc");
System.out.println(userAgentHeaders.get(0));
}

private static HttpClientDependencies dependencies(String clientUserAgent) {
Expand Down
2 changes: 2 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,8 @@
<exclude>*.internal.*</exclude>
<exclude>software.amazon.awssdk.thirdparty.*</exclude>
<exclude>software.amazon.awssdk.regions.*</exclude>
<!-- TODO revert - Temporarily disable because system setting USER_REGION was removed -->
<exclude>software.amazon.awssdk.utils.JavaSystemSetting</exclude>
</excludes>

<ignoreMissingOldVersion>true</ignoreMissingOldVersion>
Expand Down
38 changes: 0 additions & 38 deletions services/ec2/src/test/resources/log4j2.properties

This file was deleted.

0 comments on commit fcb336d

Please sign in to comment.