Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamoDbEnhancedClient: Add StreamSpecification to CreateTableEnhancedRequest #4010

Closed
1 of 2 tasks
acouvreur opened this issue May 15, 2023 · 2 comments · Fixed by #4011
Closed
1 of 2 tasks

DynamoDbEnhancedClient: Add StreamSpecification to CreateTableEnhancedRequest #4010

acouvreur opened this issue May 15, 2023 · 2 comments · Fixed by #4011
Labels
dynamodb-enhanced feature-request A feature should be added or improved.

Comments

@acouvreur
Copy link
Contributor

Describe the feature

The CreateTableEnhancedRequest should provide a streamSpecification method to allow the user to specify a StreamSpecification to generate the table schema.

Use Case

Right now when using table.createTable we cannot specify any StreamSpecification.

This means that you must create the schema using CreateTableRequest instead.

Using CreateTableRequest instead. But I'm not sure what I should create to have the same behavior as the DynamoDbTable.createTable method.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

2.20.66-SNAPSHOT

JDK version used

1.8

Operating System and version

MacOS M1 (13.3.1)
@acouvreur acouvreur added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 15, 2023
acouvreur added a commit to acouvreur/aws-sdk-java-v2 that referenced this issue May 15, 2023
@acouvreur
Add StreamSpecification to CreateTableEnhancedRequest
b1577bf 
Allows you to specify a StreamSpecification when creating a DynamoDbTable using the CreateTableOperation with the EnhancedDynamoDbClient

Closes aws#4010
acouvreur added a commit to acouvreur/aws-sdk-java-v2 that referenced this issue May 15, 2023
@acouvreur
Add StreamSpecification to CreateTableEnhancedRequest
9d799ac 
Allows you to specify a StreamSpecification when creating a DynamoDbTable using the CreateTableOperation with the EnhancedDynamoDbClient

Closes aws#4010
acouvreur added a commit to acouvreur/aws-sdk-java-v2 that referenced this issue May 15, 2023
@acouvreur
Add StreamSpecification to CreateTableEnhancedRequest
53a4bbc 
Allows you to specify a StreamSpecification when creating a DynamoDbTable using the CreateTableOperation with the EnhancedDynamoDbClient

Closes aws#4010
@acouvreur acouvreur mentioned this issue May 15, 2023
Merged
12 tasks
acouvreur added a commit to acouvreur/aws-sdk-java-v2 that referenced this issue May 16, 2023
@acouvreur
Merge branch 'master' into awsgh-4010
a17693b
@debora-ito debora-ito added needs-review This issue or PR needs review from the team. and removed needs-triage This issue or PR still needs to be triaged. labels May 18, 2023
@debora-ito debora-ito added dynamodb-enhanced and removed needs-review This issue or PR needs review from the team. labels Jun 9, 2023
@debora-ito
Copy link
Member

This feature makes sense. We'll take a look at the PR you submitted. Thank you!

joviegas added a commit to acouvreur/aws-sdk-java-v2 that referenced this issue Jun 24, 2023
@joviegas
Merge branch 'master' into awsgh-4010
eee8426
joviegas added a commit to acouvreur/aws-sdk-java-v2 that referenced this issue Jun 26, 2023
@joviegas
Merge branch 'master' into awsgh-4010
094d50c
joviegas added a commit that referenced this issue Jun 26, 2023
@acouvreur @joviegas
Add StreamSpecification to CreateTableEnhancedRequest (#4011)
e503fcc 
* Add `StreamSpecification` to `CreateTableEnhancedRequest`

Allows you to specify a StreamSpecification when creating a DynamoDbTable using the CreateTableOperation with the EnhancedDynamoDbClient

Closes #4010

* Updated the change log and java doc

---------

Co-authored-by: John Viegas <joviegas@amazon.com>
Co-authored-by: John Viegas <70235430+joviegas@users.noreply.github.com>
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

L-Applin pushed a commit that referenced this issue Jul 24, 2023
@acouvreur @joviegas @L-Applin
Add StreamSpecification to CreateTableEnhancedRequest (#4011)
4a4db06 
* Add `StreamSpecification` to `CreateTableEnhancedRequest`

Allows you to specify a StreamSpecification when creating a DynamoDbTable using the CreateTableOperation with the EnhancedDynamoDbClient

Closes #4010

* Updated the change log and java doc

---------

Co-authored-by: John Viegas <joviegas@amazon.com>
Co-authored-by: John Viegas <70235430+joviegas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dynamodb-enhanced feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add StreamSpecification to CreateTableEnhancedRequest acouvreur/aws-sdk-java-v2
2 participants
@debora-ito @acouvreur