Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StreamSpecification to CreateTableEnhancedRequest #4011

Merged
merged 5 commits into from
Jun 26, 2023
Merged

Add StreamSpecification to CreateTableEnhancedRequest #4011

merged 5 commits into from
Jun 26, 2023

Conversation

acouvreur
Copy link
Contributor

@acouvreur acouvreur commented May 15, 2023 •
edited
Loading

Allows you to specify a StreamSpecification when creating a DynamoDbTable using the CreateTableOperation with the EnhancedDynamoDbClient

Closes #4010

Motivation and Context

#4010 and awspring/spring-cloud-aws#817

This will allow users of the EnhancedDynamoDbClient to use a stream specification.

Modifications

Added StreamSpecification to the Builder, and uses it in the CreateTableOperation object

Testing

Added and executed unit tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@acouvreur
Add StreamSpecification to CreateTableEnhancedRequest
53a4bbc 
Allows you to specify a StreamSpecification when creating a DynamoDbTable using the CreateTableOperation with the EnhancedDynamoDbClient

Closes aws#4010
@acouvreur acouvreur requested a review from a team as a code owner May 15, 2023 22:02
@maciejwalkowiak maciejwalkowiak mentioned this pull request May 16, 2023
Closed
@debora-ito debora-ito added the needs-review This issue or PR needs review from the team. label Jun 8, 2023
@debora-ito debora-ito removed the needs-review This issue or PR needs review from the team. label Jun 22, 2023
joviegas
joviegas reviewed Jun 24, 2023
View reviewed changes
Copy link
Contributor

@joviegas joviegas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @acouvreur for taking time and raising the PR.
Will update this PR with recommended changes and push it .
Let me know if any concerns

.changes/next-release/feature-AmazonDynamoDB-c0398be.json Outdated Show resolved Hide resolved
@joviegas joviegas enabled auto-merge (squash) June 26, 2023 16:55
@joviegas
Copy link
Contributor

Checked why it was not originally added and came to know

The reason it wasn't added  before was because createTable in the enhanced client was not intended to replace the CDK, it was only intended to be used for integ tests using local DDB . Having specs like this really put it beyond what it was originally intended for.

@joviegas joviegas disabled auto-merge June 26, 2023 18:28
@joviegas joviegas enabled auto-merge (squash) June 26, 2023 20:52
@joviegas joviegas merged commit e503fcc into aws:master Jun 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

45.0% 45.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

L-Applin pushed a commit that referenced this pull request Jul 24, 2023
@acouvreur @joviegas @L-Applin
Add StreamSpecification to CreateTableEnhancedRequest (#4011)
4a4db06 
* Add `StreamSpecification` to `CreateTableEnhancedRequest`

Allows you to specify a StreamSpecification when creating a DynamoDbTable using the CreateTableOperation with the EnhancedDynamoDbClient

Closes #4010

* Updated the change log and java doc

---------

Co-authored-by: John Viegas <joviegas@amazon.com>
Co-authored-by: John Viegas <70235430+joviegas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joviegas joviegas joviegas approved these changes

Assignees

@joviegas joviegas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DynamoDbEnhancedClient: Add StreamSpecification to CreateTableEnhancedRequest
3 participants
@acouvreur @joviegas @debora-ito