Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaded jar third-party-jackson-core:2.20.140 has duplicate multi-jar classes #4391

Closed
dspaven opened this issue Sep 4, 2023 · 2 comments · Fixed by #4394
Closed

Shaded jar third-party-jackson-core:2.20.140 has duplicate multi-jar classes #4391

dspaven opened this issue Sep 4, 2023 · 2 comments · Fixed by #4394
Labels
bug This issue is a bug. p2 This is a standard priority issue

Comments

@dspaven
Copy link

dspaven commented Sep 4, 2023

Describe the bug

Updating to third-party-jackson-core version 2.20.140 is failing our builds due to it containing duplicate classes with jackson-core.

This appears to be a build issue with third-party-jackson-core where it creates a shaded jar of jackson-core by relocating classes to the awssdk package namespace. However, the current build configuration falls down because it doesn't relocate the jackson-core multi-release classes. So these remain in the shaded jar as multi-release classes but packaged within com.fasterxml.jackson.core - causing duplicate class conflicts.

Expected Behavior

Jackson core multi-release classes should be relocated to the appropriate awssdk package in third-party-jackson-core

Current Behavior

jackson-core multi-releases classes are not relocated.

Reproduction Steps

Inspect META-INF\versions\ in third-party-jackson-core:2.20.140

Possible Solution

No response

Additional Information/Context

No response

AWS Java SDK version used

2.20.140

JDK version used

17.0.6

Operating System and version

Windows 10

@dspaven dspaven added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 4, 2023
@debora-ito debora-ito added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2023
@debora-ito
Copy link
Member

@dspaven thank you for reaching out, a PR is in the works.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants