Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude multirelease classes in jackson #4394

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Exclude multirelease classes in jackson #4394

merged 1 commit into from
Sep 5, 2023

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Sep 5, 2023 •
edited
Loading

Fixes #4391.

Motivation and Context

Modifications

Testing

Build the JARs and unzip and verify they don't contain META-INF/versions.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir requested a review from a team as a code owner September 5, 2023 18:18
@dagnir dagnir enabled auto-merge (squash) September 5, 2023 18:24
@dagnir dagnir merged commit 34aa46d into master Sep 5, 2023
6 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.2% 75.2% Coverage
0.6% 0.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millems millems millems approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shaded jar third-party-jackson-core:2.20.140 has duplicate multi-jar classes
2 participants
@dagnir @millems