Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Service Endpoint Metric #3775

Closed
wants to merge 2 commits into from

Conversation

dave-fn
Copy link
Contributor

@dave-fn dave-fn commented Feb 17, 2023

Motivation and Context

Provide a service endpoint metric to match the SDK v1 behavior as described with issue 2579.

Modifications

Created SERVICE_ENDPOINT in CoreMetric for returning an URI.

Testing

Tested under CoreMetricsTest. Also added assert to ignored test in BaseAsyncCoreMetricsTest.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dave-fn dave-fn requested a review from a team as a code owner February 17, 2023 23:26
@dave-fn dave-fn mentioned this pull request Feb 17, 2023
12 tasks
@dave-fn dave-fn force-pushed the davidfn/bug-bash/service-endpoint-metric branch from bd7edb6 to 07b0746 Compare March 10, 2023 17:30
@dagnir dagnir mentioned this pull request Aug 15, 2023
12 tasks
@dagnir
Copy link
Contributor

dagnir commented Aug 15, 2023

Built off this in #4307. Closing this.

@dagnir dagnir closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants