Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create design doc for cross-region S3 client #3937

Closed
wants to merge 2 commits into from

Conversation

zoewangg
Copy link
Contributor

Motivation and Context

#52

Modifications

Create design doc for cross-region S3 client

@zoewangg zoewangg requested a review from a team as a code owner April 21, 2023 22:58
@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information


### Client Configuration

Users can enable this feature through a client configuration on the client builder, `crossRegionAccessEnabled`. It is default to false.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo: It is default to false
should be It is set to false by default or something like that

#### Example 1: enabling cross-region access in the S3 sync client

```
S3ClientBuilder s3ClientBuilder = S3Client.builder()
Copy link
Contributor

@joviegas joviegas Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crossRegionAcccessEnabled API will be made available to only "S3Client.builder" and not to AwsClientBuilder , right ? since it will make it available for all the clients even if its not supported.
Thus we might need to add Customization for S3 only to show this API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, alternatively, we could consider adding it to S3Configuration, I don't have strong opinions. We still need to add crossRegionAcccessEnabled to the top level S3CrtAsyncClient builder though.

@zoewangg
Copy link
Contributor Author

Closing because it's obsolete.

@zoewangg zoewangg closed this Jan 24, 2024
@zoewangg zoewangg deleted the zoewang/crossregions3client branch January 24, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants