-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create design doc for cross-region S3 client #3937
Conversation
Kudos, SonarCloud Quality Gate passed! |
|
||
### Client Configuration | ||
|
||
Users can enable this feature through a client configuration on the client builder, `crossRegionAccessEnabled`. It is default to false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo: It is default to false
should be It is set to false by default
or something like that
#### Example 1: enabling cross-region access in the S3 sync client | ||
|
||
``` | ||
S3ClientBuilder s3ClientBuilder = S3Client.builder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The crossRegionAcccessEnabled
API will be made available to only "S3Client.builder" and not to AwsClientBuilder
, right ? since it will make it available for all the clients even if its not supported.
Thus we might need to add Customization for S3 only to show this API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, alternatively, we could consider adding it to S3Configuration
, I don't have strong opinions. We still need to add crossRegionAcccessEnabled
to the top level S3CrtAsyncClient builder though.
Closing because it's obsolete. |
Motivation and Context
#52
Modifications
Create design doc for cross-region S3 client