Added support for IamPolicy in new module software.amazon.awssdk:iam-… #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…policy-builder, a class to simplify the use of AWS policies.
millems
force-pushed
the
millem/policy-builder
branch
from
9e142c2
to
aa79fd2
Compare
millems
commented
Jul 13, 2023
| ElementType.PARAMETER}) | ||
| @Retention(RetentionPolicy.CLASS) | ||
| @SdkProtectedApi | ||
| public @interface NotNull { |
There was a problem hiding this comment.
Added this because EqualsVerifier will use it to detect which fields are considered not-null. It allows me to test all of the equals/hashcode methods in the package at once from a single test (EqualsHashCodeTest).
| * | ||
| * <p>Setting this value will also override any values set via {@link #jsonFactory}. | ||
| */ | ||
| public JsonWriter.Builder jsonGeneratorFactory(JsonGeneratorFactory jsonGeneratorFactory) { |
There was a problem hiding this comment.
Added this to allow me to configure the underlying JSON generator to pretty-print the JSON.
Closed
davidh44
reviewed
Jul 14, 2023
.../iam-policy-builder/src/main/java/software/amazon/awssdk/policybuilder/iam/IamStatement.java
Outdated
Show resolved
Hide resolved
.../iam-policy-builder/src/main/java/software/amazon/awssdk/policybuilder/iam/IamStatement.java
Show resolved
Hide resolved
.../src/main/java/software/amazon/awssdk/policybuilder/iam/internal/DefaultIamPolicyReader.java
Show resolved
Hide resolved
davidh44
approved these changes
Jul 17, 2023
|
SonarCloud Quality Gate failed.
|
L-Applin
pushed a commit
that referenced
this pull request
Jul 24, 2023
#4185) * Added support for IamPolicy in new module software.amazon.awssdk:iam-policy-builder, a class to simplify the use of AWS policies. * Addressed comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…policy-builder, a class to simplify the use of AWS policies.
See IamPolicy for usage examples.
Implements #39