Remove emptyMap case that would miss additionalAuthSchemes #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
CI failing pending #4363 |
gosar
changed the base branch from
feature/master/sra-identity-auth
to
haydenbaker/master/sra-identity-auth-fixes
gosar
changed the base branch from
haydenbaker/master/sra-identity-auth-fixes
to
feature/master/sra-identity-auth
gosar
force-pushed
the
gosar/sra-ia-emptyAuthSchemes
branch
from
b2f5561
to
bcabc46
Compare
gosar
force-pushed
the
gosar/sra-ia-emptyAuthSchemes
branch
from
3d782f6
to
821f596
Compare
|
SonarCloud Quality Gate failed.
|
sugmanue
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
context: https://github.com/aws/aws-sdk-java-v2/pull/4358/files#r1308068350
Modifications
Remove emptyMap case that would miss additionalAuthSchemes
Testing
Was looking at add a test case for model with zero auth schemes (to showcase the case where concreteAuthSchemeClasses would have been empty before #4358), but the model doesn't seem to support it today.
The closest equivalent in the model is
which would still not have triggered the emptyMap case, as it would be a list of ["none"]. But since I coded it up, adding that test case anyways. It may not be directly relevant to the current model format, but whenever codegen is moved to Smithy models, this test case may serve as reminder to convert that test case to Smithy, where zero auth types is supported.