-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AddingTrailingDataSubscriber to allow users to send additional data t… #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cenedhryn
reviewed
Aug 29, 2023
utils/src/main/java/software/amazon/awssdk/utils/async/AdditionalDataSubscriber.java
Outdated
Show resolved
Hide resolved
…o the downstream subscriber
zoewangg
force-pushed
the
zoewang/additionalDataSubscriber
branch
from
August 29, 2023 19:08
5200710
to
2756b1c
Compare
zoewangg
changed the title
Add AdditionalDataSubscriber to allow users to send additional data t…
Add AddingTrailingDataSubscriber to allow users to send additional data t…
Aug 29, 2023
dagnir
reviewed
Aug 29, 2023
utils/src/main/java/software/amazon/awssdk/utils/async/AddingTrailingDataSubscriber.java
Show resolved
Hide resolved
L-Applin
reviewed
Aug 29, 2023
utils/src/main/java/software/amazon/awssdk/utils/async/AddingTrailingDataSubscriber.java
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/AddingTrailingDataSubscriber.java
Outdated
Show resolved
Hide resolved
12 tasks
SonarCloud Quality Gate failed. 0 Bugs 77.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
cenedhryn
approved these changes
Sep 1, 2023
L-Applin
approved these changes
Sep 1, 2023
dagnir
approved these changes
Sep 5, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o the downstream subscriber
Motivation and Context
There are use-cases where we want to send trailing data on top of what the publisher publishes. For example, in async signing code path, we always send a trailing empty frame.
Modifications
SdkPublisher#addTrailingData
Testing
Added TCK tests and unit tests.
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License