Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddingTrailingDataSubscriber to allow users to send additional data t… #4366

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Aug 29, 2023

…o the downstream subscriber

Motivation and Context

There are use-cases where we want to send trailing data on top of what the publisher publishes. For example, in async signing code path, we always send a trailing empty frame.

Modifications

  • Add AddingTrailingDataSubscriber to allow users to send trailling to the downstream subscriber
  • Expose SdkPublisher#addTrailingData

Testing

Added TCK tests and unit tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner August 29, 2023 18:24
@zoewangg zoewangg force-pushed the zoewang/additionalDataSubscriber branch from 5200710 to 2756b1c Compare August 29, 2023 19:08
@zoewangg zoewangg changed the title Add AdditionalDataSubscriber to allow users to send additional data t… Add AddingTrailingDataSubscriber to allow users to send additional data t… Aug 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

77.0% 77.0% Coverage
3.9% 3.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@zoewangg zoewangg merged commit f8c1cb0 into master Sep 5, 2023
12 of 13 checks passed
@zoewangg zoewangg deleted the zoewang/additionalDataSubscriber branch September 5, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants