Clean up auth schemes/signers that are no longer needed #4368
Conversation
sugmanue
force-pushed
the
sugmanue/sra-ia-cleanup-sigv4a-interfaces
branch
from
a567c29
to
a66c049
Compare
...uth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/internal/signer/SignerLoader.java
Outdated
Show resolved
Hide resolved
| @@ -38,11 +37,7 @@ private SignerLoader() { | |||
| } | |||
|
|
|||
| public static AwsV4aHttpSigner getSigV4aSigner() { | |||
There was a problem hiding this comment.
nit, because it is SdkInternalApi, but could keep the method name close to the return type - getAwsV4aHttpSIgner()
| @@ -29,20 +28,16 @@ | |||
| /** | |||
| * Utility class for instantiating signers only if they're available on the class path. | |||
| */ | |||
| @SdkInternalApi | |||
| @SdkProtectedApi | |||
There was a problem hiding this comment.
The SignerLoader itself is not used cross-module; used only by AwsV4aHttpSigner. This should remain SdkInternalApi.
There was a problem hiding this comment.
Sure, I moved it to protected to mirror the existing one, but we can relax this once and if needed. I will move it back to internal.
There was a problem hiding this comment.
fyi, the existing one is SdkProtectedApi, because it is used by generated {Service}EndpointAuthSchemeInterceptor.
| @@ -44,9 +44,16 @@ | |||
| * An implementation of a {@link AwsV4aHttpSigner} that uses properties to compose v4a-signers in order to delegate signing of a | |||
| * request and payload (if applicable) accordingly. | |||
| */ | |||
| @SdkInternalApi | |||
| @SdkProtectedApi | |||
There was a problem hiding this comment.
sorry, one more point. I think this should now be moved to software.amazon.awssdk.http.auth.aws.crt instead of under internal
There was a problem hiding this comment.
Pushed a new commit to move the class and test.
|
SonarCloud Quality Gate failed.
|
sugmanue
merged commit e5d7809
into
feature/master/sra-identity-auth
Motivation and Context
Clean up auth schemes/signers that are no longer needed. After the consolidation of all the signing logic into single classes we can remove all the special auth schemes and implementations that are not longer needed.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License