Add flexible checksum support for chunked-encoding cases #4383
Conversation
|
|
||
| public AwsChunkedV4PayloadSigner(CredentialScope credentialScope, int chunkSize) { | ||
| public AwsChunkedV4PayloadSigner(CredentialScope credentialScope, int chunkSize, ChecksumAlgorithm checksumAlgorithm) { |
There was a problem hiding this comment.
Will change this to a builder.
haydenbaker
force-pushed
the
haydenbaker/sra-ia-awssigners-flexible-checksums
branch
from
eb70caa
to
3124558
Compare
| credentialScope.getDatetime(), | ||
| credentialScope.scope(), | ||
| previousSignature, | ||
| toHex(hash(getCanonicalHeadersString(getCanonicalHeaders(headers)))) |
There was a problem hiding this comment.
Chained methods are a bit hard to read, can we create variables?
There was a problem hiding this comment.
Sure, I'll break it up
| * <p> | ||
| * The checksum-algorithm MUST be set if this is called, otherwise it will throw. | ||
| */ | ||
| private void setupChecksumTrailer(ChunkedEncodedInputStream.Builder builder, SdkHttpRequest.Builder request) { |
There was a problem hiding this comment.
Maybe we can rename it to setUpChecksumTrailerIfNeeded and return if checksumAlgorithm is null? Then we can remove the checksumAlgorithm null check from the callers
There was a problem hiding this comment.
Sure, if that's an established naming pattern, I can do that
haydenbaker
force-pushed
the
haydenbaker/sra-ia-awssigners-flexible-checksums-chunked
branch
from
f5a1a44
to
fec7712
Compare
| public interface Builder { | ||
| Builder credentialScope(CredentialScope credentialScope); | ||
|
|
||
| Builder chunkSize(int chunkSize); |
There was a problem hiding this comment.
Should probably be boxed type so that we can throw an exception or set a default if the caller doesn't set it.
|
SonarCloud Quality Gate failed.
|
haydenbaker
merged commit 8f7070b
into
feature/master/sra-identity-auth
Motivation and Context
Modifications
AwsChunkedEncodedInputStreamto take a checksum-algorithm parameterTypes of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License