[Ignore] Testing branch with useSraAuth=true #4478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into feature/master/sra-identity-auth-testing
…by new signers. (#4494)
…' into feature/master/sra-identity-auth-testing
…' into feature/master/sra-identity-auth-testing
…' into feature/master/sra-identity-auth-testing
…' into feature/master/sra-identity-auth-testing
zoewangg
force-pushed
the
feature/master/sra-identity-auth-testing
branch
from
ec19254
to
b6a9ffe
Compare
…ra-identity-auth-testing
zoewangg
force-pushed
the
feature/master/sra-identity-auth-testing
branch
from
b6a9ffe
to
ba2eab9
Compare
…' into feature/master/sra-identity-auth-testing
…' into feature/master/sra-identity-auth-testing
…' into sra-identity-auth-testing
…' into sra-identity-auth-testing
…' into sra-identity-auth-testing
…' into sra-identity-auth-testing
* Update NoneAuthTypeRequestTest for SRA clients * Update ClientBuilderTest for SRA clients
…ra-identity-auth-testing
…ra-identity-auth-testing
…ra-identity-auth-testing
…ra-identity-auth-testing
12 tasks
* Remove derived attribute logic for PRESIGNER_EXPIRATION Because of the 2 instant() calls in the write/read mappings, a basic write this attribute and read it back, would give different values. Since this attribute should only be set/read explicitly by our presigner code, we don't need this mapping logic at all. Also, update S3PresignerTest to assert isEqualTo instead of isCloseTo and remove unnecessary override * Remove PRESIGNER_EXPIRATION mirroring test
…tity-auth-testing-merge-2.21.3-SNAPSHOT
…tity-auth-testing-merge-2.21.8-SNAPSHOT
…tity-auth-testing-merge-2.21.10-SNAPSHOT
…tity-auth-testing-merge-2.21.12-SNAPSHOT
A few limitations exist in plugin's ability to affect the SDK's configuration: 1. When plugins modify the configuration at the request-level, it does not affect configuration that is "derived" from the configuration that was modified (e.g. changing the profile file does not change the region, even if the region was derived from the profile file originally). 2. Plugins do not see the default configuration applied by the client. 3. Plugins do not see and cannot modify configuration applied by customers at the request level. This PR fixes (1), except for credentials derived from profile files. Future PRs will address the remaining limitations. As a result, this PR includes many disabled and commented-out tests that will be re-enabled as these limitations are corrected. The particularly interesting/risky changes are in AwsDefaultClientBuilder, SdkDefaultClientBuilder, and AttributeMap. Major new testing of functionality is in AttributeMapTest and SdkPluginTest. This PR makes the following large changes: 1. Add support for "lazy" SDK client options. These options can be set, but not evaluated until they are read. This functionality was added in AttributeMap, which SdkClientConfiguration uses. This PR makes the following small changes and bug fixes: 1. Add support for equals and hashCode in the default endpoint provider. 2. Fixed a bug where scheduled executors specified by plugins were not treated as unmanaged. 3. Reduced the number of times that the profile file was read during client creation. 4. Add support for specifying a profile file supplier in the ClientOverrideConfiguration. 5. Changed the way "child" classes configure the AttributeMap used to create the HTTP client to match the way other configuration works.
…tity-auth-testing-merge-2.21.14-SNAPSHOT
|
SonarCloud Quality Gate failed.
|
Before this change, plugins would not see any configuration specified on the client. This limited its ability to decorate existing configuration, and diminished plugin's ability to have intuitive behavior. This PR does not fix request-level configuration. Request-level plugins do not see request-level override configuration, and request-level override configuration is still used with a higher priority than plugin configuration. This PR does establish a possible pattern for fixing this: allowing override configuration objects to modify the SdkClientConfiguration directly. Change Summary: * Default and customer-specified client configuration is now available to SdkPlugins and is also now included in the SdkClient#serviceClientConfiguration. * Updated ClientOverrideConfiguration to use SdkClientConfiguration internally, and provided internal methods for creating/retrieving these internal configuration objects. * Updated SDK-provided ServiceClientConfiguration.Builder objects to use SdkClientConfiguration internally, allowing direct modification of these objects and avoiding the need to do translation to these objects from SdkClientConfiguration. * Removed places where we copied configuration instead of using the SdkClientConfiguration as the source of truth. Minor Changes: * Fixed an issue where the non-SRA TOKEN_PROVIDER was not being set, preventing possible compatibility issues with old bearer token clients. * Simplified TokenProviders initialization logic. * Fixed a few cache-busting bugs in AttributeMap related to dependency tracking between builder copies. * Added new methods to SdkClientConfiguration and AttributeMap to allow additional ways to add/modify configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to kick off integ tests against the feature/master/sra-identity-auth-testing branch which has useSraAuth=true.