Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfigurationUpdater to the BaseClientHandler class #4516

Conversation

sugmanue
Copy link
Contributor

Motivation and Context

Request time plugin execution

Similar to client build time plugins the request time plugins will need to be able to convert from the internal configuration (SdkClientConfiguration) to the external configuration (SdkServiceClientConfiguration) class which is the type that the plugins consume. Currently the builder knows how to do that using the ConfigurationUpdater class, we now need to pass it down this to the client.

The client itself does not need it, but rather it's pass down to the client handler down to it's the base class, BaseClientHandler, the one that actually needs it. All the paths to the base class need to be augmented with this new class

  • AwsSyncClientHandler and SdkSyncClientHandler
  • AwsAsyncClientHandler and SdkAsyncClientHandler

(and base classes in between)

This change implements the changes needed to pass down the ConfigurationUpdater, from client build to the BaseClientHandler. The upcoming change will use this to invoke the plugins.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sugmanue sugmanue requested a review from a team as a code owner September 29, 2023 23:31
@sugmanue sugmanue force-pushed the sugmanue/sra-plugins-add-plugins-execution7-request branch from bc07d60 to 1f9805f Compare September 30, 2023 00:04
@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 478 Code Smells

84.7% 84.7% Coverage
4.4% 4.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sugmanue
Copy link
Contributor Author

sugmanue commented Oct 3, 2023

Closing in favor of a different approach in #4518

@sugmanue sugmanue closed this Oct 3, 2023
@sugmanue sugmanue deleted the sugmanue/sra-plugins-add-plugins-execution7-request branch October 3, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant