Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to AwsExecutionContextBuilderTest to show current behavior #4519

Closed
wants to merge 1 commit into from

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Oct 2, 2023

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar changed the title Add asserts to AwsExecutionContextBuilderTest to show current behavior Add test to AwsExecutionContextBuilderTest to show current behavior Oct 2, 2023
@gosar gosar changed the title Add test to AwsExecutionContextBuilderTest to show current behavior Add tests to AwsExecutionContextBuilderTest to show current behavior Oct 2, 2023
@gosar gosar force-pushed the gosar/master-AwsExecutionContextBuilderTest branch from 572c2ca to 74666c8 Compare October 3, 2023 06:09
@gosar gosar force-pushed the gosar/master-AwsExecutionContextBuilderTest branch from 74666c8 to f478724 Compare October 3, 2023 06:10
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gosar
Copy link
Contributor Author

gosar commented Oct 16, 2023

This PR was created just to help with #4523 which is now merged.

@gosar gosar closed this Oct 16, 2023
@gosar gosar deleted the gosar/master-AwsExecutionContextBuilderTest branch October 19, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant