Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect variable usage in S3PresignerIntegrationTest #4529

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix incorrect variable usage in S3PresignerIntegrationTest #4529

merged 1 commit into from
Oct 3, 2023

Conversation

haydenbaker
Copy link
Contributor

Motivation and Context

  • Bug in code where the test object gets deleted before tests run that depend on the object being present

Modifications

  • Fix reference to object key, delete test should use the object that was meant to be deleted

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@haydenbaker haydenbaker requested a review from a team as a code owner October 3, 2023 16:16
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 500 Code Smells

85.1% 85.1% Coverage
4.4% 4.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@haydenbaker haydenbaker merged commit a214950 into feature/master/sra-identity-auth Oct 3, 2023
13 of 14 checks passed
@haydenbaker haydenbaker deleted the haydenbaker/fix-S3PresignerIntegrationTest branch October 3, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoewangg zoewangg zoewangg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haydenbaker @zoewangg