Uncomment some previously disabled tests #4538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some tests were disabled earlier while we were working on the feature branch, as they used to fail on SRA codepath, i.e., what is now useSraAuth=true. Some of these are now fixed. Uncommenting those tests. But some still fail with useSraAuth=true. The feature branch is now defaulting to useSraAuth=false, so uncommenting even those tests, with a TODO to fix them in the useSraAuth=true testing branch (feature/master/sra-identity-auth-testing). At least, this way we've ensured these tests work for useSraAuth=false - the first stage of the release; when we merge the feature/master/sra-identity-auth branch to master, we won't be reducing the tests run.
With this, the known tests failing with useSraAuth=true are in:
Modifications
Uncomment tests, with TODOs where needed to fix for useSraAuth=true.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License