Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment some previously disabled tests #4538

Merged

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Oct 4, 2023

Motivation and Context

Some tests were disabled earlier while we were working on the feature branch, as they used to fail on SRA codepath, i.e., what is now useSraAuth=true. Some of these are now fixed. Uncommenting those tests. But some still fail with useSraAuth=true. The feature branch is now defaulting to useSraAuth=false, so uncommenting even those tests, with a TODO to fix them in the useSraAuth=true testing branch (feature/master/sra-identity-auth-testing). At least, this way we've ensured these tests work for useSraAuth=false - the first stage of the release; when we merge the feature/master/sra-identity-auth branch to master, we won't be reducing the tests run.

With this, the known tests failing with useSraAuth=true are in:

  1. EventMarshallingTest
  2. protocolrestjson/AsyncOperationCancelTest
  3. MultiRegionAccessPointEndpointResolutionTest
  4. NoneAuthTypeRequestTest

Modifications

Uncomment tests, with TODOs where needed to fix for useSraAuth=true.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

They work with both useSraAuth=false/true.
Leaving the TODO as it still fails for useSraAuth=true.
Leaving the TODO as it still fails for useSraAuth=true.
They work with both useSraAuth=false/true.
Leaving the TODO as it still fails for useSraAuth=true.
@gosar gosar requested a review from a team as a code owner October 4, 2023 06:30
@gosar gosar enabled auto-merge (squash) October 4, 2023 06:39
@gosar gosar merged commit f1b4d50 into feature/master/sra-identity-auth Oct 4, 2023
6 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 485 Code Smells

85.2% 85.2% Coverage
4.2% 4.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Contributor

@sugmanue sugmanue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gosar gosar deleted the gosar/sra-ia-uncomment-tests branch October 4, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants