Do not re-use sanitized request when forming signed request

[haydenbaker]

Motivation and Context

• Before signing a request with CRT, a request is sanitized (forbidden headers/params are removed, encoded-path is set to / if path is empty, etc)
• After signing, we should use the original request when forming the signed request, instead of the sanitized one, such that original metadata is not lost (headers, params, path, etc.)

Modifications

• Update signer to use original request when converting to signed request
• Remove TODOs in tests

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[gosar]

I'm treating the comments as non-blocking for the release.

[gosar]

can we do

        SdkHttpRequest.Builder requestBuilder = request.request().toBuilder();

        payloadSigner.beforeSigning(requestBuilder, request.payload().orElse(null), signingConfig.getSignedBodyValue());

        // The requestBuilder changes should be done now.
       SdkHttpRequest requestToSign = requestBuilder.build();

        SdkHttpRequest sanitizedRequest = sanitizeRequest(requestToSign);

        HttpRequest crtRequest = toRequest(sanitizedRequest, request.payload().orElse(null));

        V4aContext v4aContext = sign(requestToSign, crtRequest, signingConfig);

[gosar]

And I know we have the MultiRegionAccessPointEndpointResolutionTest test, but is worth adding a unit test to this module.

[gosar]

you didn't call it out, but I assume you tested this with useSraAuth=true

[sonarcloud]

SonarCloud Quality Gate failed.   

9 Bugs
0 Vulnerabilities
2 Security Hotspots
481 Code Smells

85.5% Coverage
4.2% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint