Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment previously disabled AsyncHttpChecksumIntegrationTest #4545

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Uncomment previously disabled AsyncHttpChecksumIntegrationTest #4545

merged 2 commits into from
Oct 4, 2023

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Oct 4, 2023

Motivation and Context

They were commented out in #4503.

Modifications

Enabled those tests, and update TODO comment.

Testing

Ran those tests locally with both useSraAuth=false/true.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar requested a review from a team as a code owner October 4, 2023 19:37
@gosar gosar force-pushed the gosar/sra-ia-AsyncHttpChecksumIntegrationTest branch from 36b773c to db5a488 Compare October 4, 2023 21:31
@gosar gosar enabled auto-merge (squash) October 4, 2023 21:39
@gosar gosar merged commit 55b9d34 into feature/master/sra-identity-auth Oct 4, 2023
6 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 480 Code Smells

85.5% 85.5% Coverage
4.2% 4.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gosar gosar deleted the gosar/sra-ia-AsyncHttpChecksumIntegrationTest branch October 4, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cenedhryn cenedhryn cenedhryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gosar @cenedhryn