Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codegen-generated-classes-test for SRA #4548

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Oct 4, 2023

Motivation and Context

These are the 2 failing tests for codegen-generated-classes-test with useSraAuth=true (in the feature/master/sra-identity-auth-testing branch). Updating the tests for SRA. We would merge this to master, towards the end of the release, once useSraAuth=true in master.

The ClientBuilder tests actually should be updated to assert for SRA types, but just made it a TODO for now, to get the branch to green first.

Modifications

Update tests.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar requested a review from a team as a code owner October 4, 2023 23:23
@gosar gosar merged commit e0ebe0e into feature/master/sra-identity-auth-testing Oct 4, 2023
2 of 12 checks passed
@gosar gosar deleted the gosar/sra-ia-testing-branch-tests branch October 4, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants