Fail codegen for Query protocol operations with explicit String payload #4553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
reviewed
Oct 6, 2023
| @@ -73,7 +74,7 @@ private static boolean isBlobShape(Shape shape) { | |||
| * @return True if shape is a String type. False otherwise | |||
| */ | |||
| private static boolean isStringShape(Shape shape) { | |||
| return shape != null && "String".equals(shape.getType()); | |||
| return shape != null && shape.getType().equalsIgnoreCase("String"); | |||
There was a problem hiding this comment.
Let's keep the original ordering and compare to the constant: "String".equalsIgnoreCase(shape.getType())
| @@ -179,6 +180,12 @@ public Map<String, OperationModel> constructOperations() { | |||
| if (input != null) { | |||
| String originalShapeName = input.getShape(); | |||
| String inputShape = namingStrategy.getRequestClassName(operationName); | |||
|
|
|||
| if (isQueryProtocolWithExplicitStringPayload(c2jShapes, c2jShapes.get(inputShape))) { | |||
There was a problem hiding this comment.
I don't like the idea of doing validation in here since we're not doing it for anything else. Can we do this validation as a preprocessor instead?
There was a problem hiding this comment.
makes sense, moving to preproccesor
|
Kudos, SonarCloud Quality Gate passed! |
dagnir
approved these changes
Oct 6, 2023
davidh44
deleted the
hdavidh/fail-codegen-string-payload-query-protocol
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Explicit String payloads are not supported for Query protocols
Modifications
Update codegen to fail if there is Query protocol operation with explicit String payload
Update Json codegen test classes which were missed in previous PR -
stringcan be lowercase when callingshape.getType()Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License