Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move QueryParametersToBodyInterceptor to pipeline stage #4561

Merged
merged 14 commits into from
Oct 23, 2023
Merged

Move QueryParametersToBodyInterceptor to pipeline stage #4561

merged 14 commits into from
Oct 23, 2023

Conversation

davidh44
Copy link
Contributor

@davidh44 davidh44 commented Oct 6, 2023 •
edited
Loading

Motivation and Context

Allow for custom query params to be set through RequestOverrideConfiguration

Modifications

Move QueryParametersToBodyInterceptor to new pipeline stage QueryParametersToBodyStage
Add new SdkProtocolMetadata, AwsProtocolMetadata ,PROTOCOL_METADATA SdkExecutionAttribute to check for and only modify query protocols during stage execution

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@davidh44 davidh44 requested a review from a team as a code owner October 6, 2023 23:30
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 8 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

82.8% 82.8% Coverage
0.3% 0.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@davidh44 davidh44 merged commit 04dffd7 into master Oct 23, 2023
13 of 14 checks passed
@davidh44 davidh44 deleted the hdavidh/allow-custom-query-params-query-protocol branch October 23, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagnir dagnir dagnir approved these changes

@cenedhryn cenedhryn cenedhryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidh44 @dagnir @cenedhryn