Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log entry for releasing updated core for SRA Identity & Auth #4571

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Oct 10, 2023

Motivation and Context

Add changelog entry for the SDK core release for SRA Identity & Auth. Will merge this to the feature/master/sra-identity-auth branch first, before merging feature/master/sra-identity-auth to master (as part of #4509)

Modifications

Ran ./scripts/new-change

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar marked this pull request as ready for review October 10, 2023 18:56
@gosar gosar requested a review from a team as a code owner October 10, 2023 18:56
"type": "feature",
"category": "AWS SDK for Java v2",
"contributor": "gosar",
"description": "This release contains a major internal refactor of authentication. The refactor is part of moving the SDK to Smithy Reference Architecture.\n\nIt paves the way for new features to be released over the coming months, e.g., SDK plugins and custom auth schemes. These will be released to individual service SDKs in a phased rollout.\n\nAlso, with this release:\n* custom 3rd party credential providers can be created with fewer SDK dependencies.\n* new signers can be used with fewer SDK dependencies.\n\nSince this is a major refactor, this release bumps the minor version of the SDK to 2.21. So keep an eye out for behavioral changes."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a link for the smithy reference architecture? Or should we just say "a standardized AWS SDK architecture"

Copy link
Contributor

@millems millems Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

This release contains a major internal refactor of authentication. The refactor is part of moving the SDK to a standardized AWS SDK architecture.

It paves the way for new features to be released over the coming months: SDK plugins to provide a unified interface to add third-party functionality to the SDK and the ability to define additional ways of authenticating with services.

With this release, custom 3rd party credential providers can be created with fewer SDK dependencies (with the new identity-spi module), and AWS signers can be used with fewer SDK dependencies (with the new http-auth-aws module).

Because this is a major refactor that may result in backwards-compatible behavior changes, this release bumps the minor version of the SDK to 2.21."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's planned to be published in Q4. I thought better to atleast use that terminology, so that later when someone is looking, they'll find it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with Matt's suggestion

@millems millems enabled auto-merge (squash) October 12, 2023 16:48
@aws-sdk-java-automation aws-sdk-java-automation merged commit 750ed27 into feature/master/sra-identity-auth Oct 12, 2023
7 checks passed
@gosar gosar deleted the gosar/sra-ia-changelog branch October 12, 2023 16:58
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 494 Code Smells

84.9% 84.9% Coverage
4.2% 4.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants