Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unexpected changes from earlier merges and some TODOs #4574

Merged
merged 11 commits into from
Oct 12, 2023
Merged

Cleanup unexpected changes from earlier merges and some TODOs #4574

merged 11 commits into from
Oct 12, 2023

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Oct 11, 2023 •
edited
Loading

Motivation and Context

Addressing a few small things that came up looking at the diff in #4509

Modifications

  • Undoing the unexpected diffs.
  • cleanup some TODOs
  • Re-added failOnWarning=true for maven-dependency-plugin and fixed failures that it revealed

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar requested a review from a team as a code owner October 11, 2023 08:33
@gosar gosar requested a review from sugmanue October 11, 2023 17:29
@gosar gosar mentioned this pull request Oct 11, 2023
Merged
12 tasks
@gosar gosar changed the title Cleanup unexpected changes from earlier merges Address few things before merge to master Oct 12, 2023
@gosar gosar changed the title Address few things before merge to master Address few things for merge to master Oct 12, 2023
@gosar gosar changed the title Address few things for merge to master Cleanup unexpected changes from earlier merges and some TODOs Oct 12, 2023
@gosar gosar force-pushed the gosar/sra-ia-merge-to-master-cleanup branch from 2d8fd46 to f91fc62 Compare October 12, 2023 02:01
@gosar gosar force-pushed the gosar/sra-ia-merge-to-master-cleanup branch from f91fc62 to f2536e1 Compare October 12, 2023 02:04
@gosar
Update TODO in AsyncSignerOverrideTest
e0af05e
@gosar
Remove async related dead code path from SigningStage
f2db832
@gosar
Make http-auth-aws -> eventstream optional
a63b883
@gosar
Override maven-depedency-plugin for http-auth-aws-crt/eventstream
78304d7
@gosar
Add aws-crt as optional dependency from http-auth-aws
0413eb2 
It is a used but undeclared depenency causing maven-dependency-plugin
to fail. Making it optional similar to http-auth-aws-crt.
@gosar
Fix maven-dependency-plugin failures for services
215cc52 
* SdkClientConfigurationUtil which is code generated in each service
  depends on ProfileFileSupplier from profiles module.

* All services will need http-auth for useSraAuth=true for dependency
  on NoAuthAuthScheme. But get unused declared dependency failure when
  useSraAuth=false. So temporarily ignoring it until we are fully on
  SRA Identity & Auth.
@gosar
Fix all maven-dependency-plugin failures
d7c2125
@gosar gosar force-pushed the gosar/sra-ia-merge-to-master-cleanup branch from f2536e1 to d7c2125 Compare October 12, 2023 07:40
@gosar gosar mentioned this pull request Oct 12, 2023
Merged
12 tasks
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 494 Code Smells

84.9% 84.9% Coverage
4.3% 4.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gosar gosar merged commit 93b48fa into feature/master/sra-identity-auth Oct 12, 2023
16 of 17 checks passed
@gosar gosar deleted the gosar/sra-ia-merge-to-master-cleanup branch October 12, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugmanue sugmanue sugmanue approved these changes

@cenedhryn cenedhryn cenedhryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gosar @cenedhryn @sugmanue