Lets AsyncSignedRequest and SignedRequest implement CopyableBuilder #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o signed requests can be modified
gosar
approved these changes
Oct 18, 2023
Comment on lines
23
to
24
| import software.amazon.awssdk.utils.builder.CopyableBuilder; | ||
| import software.amazon.awssdk.utils.builder.ToCopyableBuilder; |
| @@ -15,6 +15,7 @@ | |||
|
|
|||
| package software.amazon.awssdk.http.auth.spi.internal.signer; | |||
|
|
|||
| import java.util.Objects; | |||
There was a problem hiding this comment.
yeah I missed running checkstyle locally, fixing...
… updating spotbugs check
millems
reviewed
Oct 31, 2023
Comment on lines
433
to
436
| List<String> concreteClassBuilderFields = builderFields.get(concreteClass); | ||
| if (concreteClassBuilderFields == null) { | ||
| concreteClassBuilderFields = new ArrayList<>(); | ||
| } |
There was a problem hiding this comment.
That'd be nice(r)
millems
approved these changes
Oct 31, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In the new signing flow, the input to the signer is a SignRequest (AsyncSignRequest) and the output is a SignedRequest (AsyncSignedRequest). SignRequest implements CopyableBuilder which means it supports
toBuilderandcopy, but SignedRequest does not. For use cases where a SignedRequest needs modification, for instance to manipulate headers in the SdkHttpRequest within the SignedRequest, it should implement this interfaceModifications
CopyableBuilderDefaultNoAuthAuthSchemaand instead lets that (anonymous) signer use the default buildersTesting
Unit tested
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License