Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert RESOLVED_CHECKSUM_SPECS mapping for SRA #4621

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Revert RESOLVED_CHECKSUM_SPECS mapping for SRA #4621

merged 3 commits into from
Oct 20, 2023

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Oct 20, 2023 •
edited
Loading

Motivation and Context

Fix for #4608.

Modifications

This is reverting the read/write mapping logic for checksum related execution attribute (RESOLVED_CHECKSUM_SPECS) that was introduced in https://github.com/aws/aws-sdk-java-v2/pull/4452/files#diff-933c20d96318c11c8224fcd3904f17bad1614606bd1d934e17bb719d99b183be to support SRA SignerProperty for the same. With this revert, flexible checksums (used only by SRA) will to not work with useSraAuth=true, but this is a minimal fix to resolve the issue, and we can make a different fix with SRA support later.

Testing

Ran regular tests in CI, as well as integration/stability tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar force-pushed the gosar/sra-ia-revert-checksum-mapping branch from 3168d85 to 0948d5e Compare October 20, 2023 19:48
@gosar gosar mentioned this pull request Oct 20, 2023
Merged
12 tasks
@gosar gosar changed the title [Draft] Revert RESOLVED_CHECKSUM_SPECS mapping for SRA Revert RESOLVED_CHECKSUM_SPECS mapping for SRA Oct 20, 2023
@gosar gosar marked this pull request as ready for review October 20, 2023 23:17
@gosar gosar requested a review from a team as a code owner October 20, 2023 23:17
@dagnir dagnir enabled auto-merge (squash) October 20, 2023 23:25
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dagnir dagnir merged commit 7079a1e into master Oct 20, 2023
17 checks passed
@gosar gosar deleted the gosar/sra-ia-revert-checksum-mapping branch October 20, 2023 23:35
@dagnir dagnir mentioned this pull request Oct 23, 2023
Closed
@joviegas joviegas mentioned this pull request Dec 8, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millems millems millems approved these changes

@haydenbaker haydenbaker haydenbaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gosar @millems @haydenbaker @dagnir