Update signer payload-signing conditional to honor PAYLOAD_SIGNING_ENABLED when payload is null

[haydenbaker]

Motivation and Context

• Prior to SRA, certain signers (i.e. Aws4UnsignedPayloadSigner) enforce usage of payload-signing when HTTP (not HTTPS) is used
• SRA tries to keep this behavior, but there is no way to force the signer to do unsigned-payload with HTTP (this PR changes this)
• Presigned requests will not have a payload, so UNSIGNED-PAYLOAD should always be used in this case.
• Addresses Signature created with S3Presigner changed in 2.21.16+ when used with endpointOverride and http address #4697

Modifications

• Updates the conditionals for checking whether to sign the payload or not
  • If PAYLOAD_SIGNING_ENABLED is set to false, we will honor that if the payload is not present (such as in the case of presigned requests), otherwise, we will still sign the payload (for security)

Testing

• Ran local integration tests for s3, all passed
• Ran unit tests for all signers and s3

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[millems]

These look like the same conditions. Under what conditions would they return different results before and after this change?

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

75.0% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint