[NOT Approved]Disable useEnvironmentVariableValues by default because of regression issue #4728

.changes/next-release/bugfix-AWSSDKforJavav2-34a2686.json

@@ -0,0 +1,6 @@
+{
+    "type": "bugfix",
+    "category": "AWS SDK for Java v2\"",
+    "contributor": "",
+    "description": "Disabling the useEnvironmentVariableValues by default for all Http clients since it caused regression issues as Issue [#4728](https://github.com/aws/aws-sdk-java-v2/issues/4728)"
+}

core/crt-core/src/main/java/software/amazon/awssdk/crtcore/CrtProxyConfiguration.java

@@ -20,6 +20,7 @@
 import java.util.Objects;
 import software.amazon.awssdk.annotations.SdkPublicApi;
 import software.amazon.awssdk.utils.ProxyConfigProvider;
+import software.amazon.awssdk.utils.ProxyEnvironmentSetting;
 import software.amazon.awssdk.utils.ProxySystemSetting;
 import software.amazon.awssdk.utils.StringUtils;
 
@@ -240,10 +241,11 @@ public interface Builder {
         Builder useSystemPropertyValues(Boolean useSystemPropertyValues);
 
         /**
-         * The option whether to use environment variable values from {@link ProxySystemSetting} if any of the config options are
-         * missing. The value is set to "true" by default which means SDK will automatically use environment variable values if
-         * options are not provided during building the {@link CrtProxyConfiguration} object. To disable this behavior, set this
-         * value to false.It is important to note that when this property is set to "true," all proxy settings will exclusively
+         * The option whether to use environment variable values from {@link ProxyEnvironmentSetting} if any of the config options
+         * are missing.
+         * The value is set to "false" by default which means SDK will not automatically use environment variable values if
+         * options are not provided during building the {@link CrtProxyConfiguration} object. To enable this behavior, set this
+         * value to true. It is important to note that when this property is set to "true," all proxy settings will exclusively
          * originate from environment variableValues, and no partial settings will be obtained from SystemPropertyValues.
          *
          * @param useEnvironmentVariableValues The option whether to use environment variable values
@@ -263,7 +265,7 @@ protected abstract static class DefaultBuilder<B extends Builder> implements Bui
         private String username;
         private String password;
         private Boolean useSystemPropertyValues = Boolean.TRUE;
-        private Boolean useEnvironmentVariableValues = Boolean.TRUE;
+        private Boolean useEnvironmentVariableValues = Boolean.FALSE;
 
         protected DefaultBuilder() {
         }

http-clients/apache-client/src/main/java/software/amazon/awssdk/http/apache/ProxyConfiguration.java

@@ -24,6 +24,7 @@
 import java.util.Set;
 import software.amazon.awssdk.annotations.SdkPublicApi;
 import software.amazon.awssdk.utils.ProxyConfigProvider;
+import software.amazon.awssdk.utils.ProxyEnvironmentSetting;
 import software.amazon.awssdk.utils.ProxySystemSetting;
 import software.amazon.awssdk.utils.ToString;
 import software.amazon.awssdk.utils.Validate;
@@ -285,13 +286,12 @@ public interface Builder extends CopyableBuilder<Builder, ProxyConfiguration> {
         Builder useSystemPropertyValues(Boolean useSystemPropertyValues);
 
         /**
-         * Option whether to use environment variable values for proxy configuration if any of the config options are missing.
-         * <p>
-         * This value is set to "true" by default, which means the SDK will automatically use environment variable values for
-         * proxy configuration options that are not provided during the building of the {@link ProxyConfiguration} object. To
-         * disable this behavior, set this value to "false". It is important to note that when this property is set to "true," all
-         * proxy settings will exclusively originate from environment variableValues, and no partial settings will be obtained
-         * from SystemPropertyValues.
+         * Option whether to use environment variable values from {@link ProxyEnvironmentSetting} if any of the config options are
+         * missing. This value is set to "false" by default, which means SDK will not automatically use environment variable
+         * values for options that are not provided during building of  {@link ProxyConfiguration} object. To enable this
+         * behavior, set this value to "true".It is important to note that when this property is set to "true," all proxy
+         * settings will exclusively originate from environment variableValues, and no partial settings will be obtained from
+         * SystemPropertyValues.
          *
          * @param useEnvironmentVariableValues The option whether to use environment variable values.
          * @return This object for method chaining.
@@ -323,7 +323,7 @@ private static final class DefaultClientProxyConfigurationBuilder implements Bui
         private Set<String> nonProxyHosts;
         private Boolean preemptiveBasicAuthenticationEnabled;
         private Boolean useSystemPropertyValues = Boolean.TRUE;
-        private Boolean useEnvironmentVariableValues = Boolean.TRUE;
+        private Boolean useEnvironmentVariableValues = Boolean.FALSE;
         private String scheme = "http";
 
         @Override

http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/ProxyConfiguration.java

@@ -273,12 +273,12 @@ public interface Builder extends CopyableBuilder<Builder, ProxyConfiguration> {
 
 
         /**
-         * Set the option whether to use environment variable values for {@link ProxyEnvironmentSetting} if any of the config
-         * options are missing. The value is set to "true" by default, enabling the SDK to automatically use environment variable
-         * values for proxy configuration options that are not provided during building the {@link ProxyConfiguration} object. To
-         * disable this behavior, set this value to "false".It is important to note that when this property is set to "true," all
-         * proxy settings will exclusively originate from Environment Variable Values, and no partial settings will be obtained
-         * from System Property Values.
+         * Option whether to use environment variable values from {@link ProxyEnvironmentSetting} if any of the config options are
+         * missing. This value is set to "false" by default, which means SDK will not automatically use environment variable
+         * values for options that are not provided during building of  {@link ProxyConfiguration} object. To enable this
+         * behavior, set this value to "true".It is important to note that when this property is set to "true," all proxy
+         * settings will exclusively originate from environment variableValues, and no partial settings will be obtained from
+         * SystemPropertyValues.
          *
          * @param useEnvironmentVariablesValues The option whether to use environment variable values
          * @return This object for method chaining.
@@ -295,7 +295,7 @@ private static final class BuilderImpl implements Builder {
         private String password;
         private Set<String> nonProxyHosts;
         private Boolean useSystemPropertyValues = Boolean.TRUE;
-        private Boolean useEnvironmentVariablesValues = Boolean.TRUE;
+        private Boolean useEnvironmentVariablesValues = Boolean.FALSE;
 
         private BuilderImpl() {
         }

http-clients/url-connection-client/src/main/java/software/amazon/awssdk/http/urlconnection/ProxyConfiguration.java

@@ -241,10 +241,11 @@ public interface Builder extends CopyableBuilder<Builder, ProxyConfiguration> {
 
         /**
          * Option whether to use environment variable values from {@link ProxyEnvironmentSetting} if any of the config options are
-         * missing. This value is set to "true" by default, which means SDK will automatically use environment variable values for
-         * options that are not provided during building the {@link ProxyConfiguration} object. To disable this behavior, set this
-         * value to "false".It is important to note that when this property is set to "true," all proxy settings will exclusively
-         * originate from environment variableValues, and no partial settings will be obtained from SystemPropertyValues.
+         * missing. This value is set to "false" by default, which means SDK will not automatically use environment variable
+         * values for options that are not provided during building of  {@link ProxyConfiguration} object. To enable this
+         * behavior, set this value to "true".It is important to note that when this property is set to "true," all proxy
+         * settings will exclusively originate from environment variableValues, and no partial settings will be obtained from
+         * SystemPropertyValues.
          *
          * @param useEnvironmentVariablesValues The option whether to use environment variable values
          * @return This object for method chaining.
@@ -273,7 +274,7 @@ private static final class DefaultClientProxyConfigurationBuilder implements Bui
         private String password;
         private Set<String> nonProxyHosts;
         private Boolean useSystemPropertyValues = Boolean.TRUE;
-        private Boolean useEnvironmentVariablesValues = Boolean.TRUE;
+        private Boolean useEnvironmentVariablesValues = Boolean.FALSE;
 
         @Override
         public Builder endpoint(URI endpoint) {

test/http-client-tests/src/main/java/software/amazon/awssdk/http/proxy/ProxyConfigCommonTestData.java

@@ -90,7 +90,7 @@ public static Stream<Arguments> proxyConfigurationSetting() {
                 + "when using the default proxy builder, the proxy configuration is resolved to use environment variables.",
                 Collections.singletonList(Pair.of("", "")),
                 environmentSettings(),
-                new TestProxySetting(), null, null, getEnvironmentVariableProxySettings()),
+                new TestProxySetting(), null, null, new TestProxySetting()),
 
             Arguments.of(
                 "Provided with no system property and valid environment variables, when using the host,"
@@ -119,7 +119,7 @@ public static Stream<Arguments> proxyConfigurationSetting() {
                 + "then proxy resolved to environment",
                 Collections.singletonList(Pair.of("", "")),
                 environmentSettings(),
-                null, true, null, getEnvironmentVariableProxySettings()),
+                null, true, null, new TestProxySetting()),
 
             Arguments.of(
                 "Provided only environment variable when useEnvironmentVariable set to false then proxy resolved "