Bugfix to support comma separated values in no_proxy environment settings

[joviegas]

Motivation and Context

4703

Root Cause

• The logic to parse no_proxy environment variables for multiple host used logic same as that of System property NO_PROXY setting which treated "|" as separator

• Why was this missed in testing ?

  • ProxyConfigurationTest had added a test case to test multiple hosts scenario. Unfortunately the test had a typo error where hosts names were added in double quotes instead of separate string.

Modifications

• Added logic to split string based on "," instead of "|".
• Added logic to trim extra spaces
• We are not adding greedy to non-greedy since it can cause issues if user already sends a non-greedy string. Wild cards are passed as it is.

New revision

After offline Discussion with @zoewangg updated this to be consistent as V1-here and V1-Here supporting both commas and pipes.

Testing

• Junits added

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

License

• I confirm that this pull request can be released under the Apache 2 license

[zoewangg]

Can we update Javadocs for ProxyConfiguration.Builder#useEnvironmentVariableValues to mention this behavior? We have proxy config class for every http client, hopefully it's not too much copy paste

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
15 Code Smells

78.1% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint