Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Default Progress Snapshot and RequestProgress class #4780

Merged
merged 20 commits into from
Dec 21, 2023

Conversation

anirudh9391
Copy link
Contributor

Implement a default progress snapshot class and a request progress class.

Motivation and Context

V2 feature parity to implement generic progress listeners

Modifications

Created new classes to implement ProgressSnapshot interface and SdkRequestProgress interface.

Testing

Unit Test

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)

Checklist

  • [x ] I have read the CONTRIBUTING document
  • [x ] Local run of mvn install succeeds
  • [ x] My code follows the code style of this project
  • [x ] My change requires a change to the Javadoc documentation
  • [x ] I have updated the Javadoc documentation accordingly
  • [ x] I have added tests to cover my changes
  • [x ] All new and existing tests passed
  • [x ] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • [ x] My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [ x] I confirm that this pull request can be released under the Apache 2 license

@anirudh9391 anirudh9391 requested a review from a team as a code owner December 14, 2023 11:01
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

72.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@anirudh9391 anirudh9391 merged commit 2ecc550 into feature/anirudkr-progress-listener Dec 21, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants