-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Default Progress Snapshot and RequestProgress class #4780
Merged
anirudh9391
merged 20 commits into
feature/anirudkr-progress-listener
from
dev/progress-listener
Dec 21, 2023
Merged
Implement Default Progress Snapshot and RequestProgress class #4780
anirudh9391
merged 20 commits into
feature/anirudkr-progress-listener
from
dev/progress-listener
Dec 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
reviewed
Dec 14, 2023
...e/src/main/java/software/amazon/awssdk/core/progress/listener/DefaultSdkRequestProgress.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/software/amazon/awssdk/core/progress/snapshot/DefaultProgressSnapshot.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/software/amazon/awssdk/core/progress/snapshot/DefaultProgressSnapshot.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/software/amazon/awssdk/core/progress/snapshot/DefaultProgressSnapshot.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/software/amazon/awssdk/core/progress/snapshot/DefaultProgressSnapshot.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/software/amazon/awssdk/core/progress/snapshot/DefaultProgressSnapshot.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/software/amazon/awssdk/core/progress/snapshot/DefaultProgressSnapshot.java
Outdated
Show resolved
Hide resolved
...sdk-core/src/test/java/software/amazon/awssdk/core/progress/DefaultProgressSnapshotTest.java
Outdated
Show resolved
Hide resolved
zoewangg
approved these changes
Dec 20, 2023
Quality Gate failedFailed conditions 72.7% Coverage on New Code (required ≥ 80%) |
anirudh9391
merged commit Dec 21, 2023
2ecc550
into
feature/anirudkr-progress-listener
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a default progress snapshot class and a request progress class.
Motivation and Context
V2 feature parity to implement generic progress listeners
Modifications
Created new classes to implement ProgressSnapshot interface and SdkRequestProgress interface.
Testing
Unit Test
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License