Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify aws-core -> http-auth-aws as test dependency #4784

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Dec 14, 2023

Motivation and Context

In the PR to switch S3 to SRA, aws-core -> http-auth-aws dependency was added here but it only needs to be a test dependency because of this change

It is safe to remove this explicit dependency from aws-core -> http-auth-aws. It is still being transitively brought it via aws-core -> sdk-core -> http-auth-aws, so it shouldn't affect customers specifying a dependency on aws-core but using classes from http-auth-aws without declaring explicit dependency.

Modifications

Made the dependency only test scope.

Testing

./mvnw clean install -pl :aws-core passes locally.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar requested a review from a team as a code owner December 14, 2023 22:38
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gosar gosar merged commit 2015471 into master Dec 15, 2023
14 checks passed
@gosar gosar deleted the gosar/aws-core-http-auth-aws-test-dependency branch December 15, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants