Wait until response body or error body received to process request #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
reviewed
Dec 15, 2023
...c/main/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtResponseHandlerAdapter.java
Outdated
Show resolved
Hide resolved
...c/main/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtResponseHandlerAdapter.java
Outdated
Show resolved
Hide resolved
dagnir
force-pushed
the
dongie/s3-crt-response-handling
branch
3 times, most recently
from
c930453
to
861440e
Compare
zoewangg
approved these changes
Dec 20, 2023
...c/main/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtResponseHandlerAdapter.java
Show resolved
Hide resolved
|
Can we also add motivation for this change and change log entry? |
dagnir
force-pushed
the
dongie/s3-crt-response-handling
branch
from
861440e
to
614c1ad
Compare
dagnir
force-pushed
the
dongie/s3-crt-response-handling
branch
from
614c1ad
to
35598f9
Compare
Done |
|
dagnir
added a commit
that referenced
this pull request
Dec 22, 2023
* Fix ChecksumIntegrationTest - Some tests specificy a part number, but CRT may do a range get under the hood. S3 will throw an error if both a range and part number are specified. This is an issue that needs to be fixed in CRT, but part number is not required in this test, so removing it. - Rename test file to CrtCheckIntegrationTest so it gets added to CRT test suite * Revert "Revert "Wait until response body or error body received to process request (#4786)"" This reverts commit 045bcc4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This fixes issue reported in #4684. Basically, in situations where the identity used to call
s3.getObject()has permissions to successfully perform aHeadObjectbut not aGetObject(i.e. this results in an error response), the S3 client thinks the the call was actually successful (becauseHeadObjectwas successful) and returns the error response content as the object content.Modifications
onResponseHeadersbecause these are not indicative if whether the request succeeded. Move calls toresponseHandler.onHeanders()toonResponseBodyandonFinishedTesting
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License