Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Port system properties: changed log level from error to warning #4793

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

debora-ito
Copy link
Member

@debora-ito debora-ito commented Dec 18, 2023

Currently, the exception is already ignored but logged as error, which can be confusing.

This changes the log level to warning.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@debora-ito debora-ito requested a review from a team as a code owner December 18, 2023 23:33
Copy link
Contributor

@joviegas joviegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be coonsistent we should do the same for silentlyGetUrl in
ProxyEnvironmentVariableConfigProvider.

@debora-ito
Copy link
Member Author

To be coonsistent we should do the same for silentlyGetUrl in ProxyEnvironmentVariableConfigProvider.

Done. I also removed the "stringUrl" from the message in this case, as the url is printed in the MalformedURLException:

2023-12-19 18:33:55 [main] ERROR software.amazon.awssdk.utils.internal.proxy.ProxyEnvironmentVariableConfigProvider:75 - Malformed proxy config environment variable localhost.com
java.net.MalformedURLException: no protocol: localhost.com
	at java.net.URL.<init>(URL.java:645) ~[?:?]
	at java.net.URL.<init>(URL.java:541) ~[?:?]
	at java.net.URL.<init>(URL.java:488) ~[?:?]
	at software.amazon.awssdk.utils.internal.proxy.ProxyEnvironmentVariableConfigProvider.silentlyGetUrl(ProxyEnvironmentVariableConfigProvider.java:58) ~[utils-2.22.2.jar:?]
	at software.amazon.awssdk.utils.internal.proxy.ProxyEnvironmentVariableConfigProvider.<init>(ProxyEnvironmentVariableConfigProvider.java:49) ~[utils-2.22.2.jar:?]
	at software.amazon.awssdk.utils.ProxyConfigProvider.fromEnvironmentSettings(ProxyConfigProvider.java:57) ~[utils-2.22.2.jar:?]
	at software.amazon.awssdk.utils.ProxyConfigProvider.fromSystemEnvironmentSettings(ProxyConfigProvider.java:85) ~[utils-2.22.2.jar:?]
	at software.amazon.awssdk.http.apache.ProxyConfiguration.<init>(ProxyConfiguration.java:58) ~[apache-client-2.22.2.jar:?]

Copy link

sonarcloud bot commented Dec 20, 2023

@debora-ito debora-ito merged commit 573699c into aws:master Dec 20, 2023
7 of 14 checks passed
@debora-ito debora-ito deleted the proxy-log-warning branch December 27, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants